Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/analysis_server/test/services/search/search_engine_test.dart

Issue 2959273002: Report only private members in the same library as overrides. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/search/search_engine_test.dart
diff --git a/pkg/analysis_server/test/services/search/search_engine_test.dart b/pkg/analysis_server/test/services/search/search_engine_test.dart
index 04ef87313b65e312ada041bc66c36dd2b33d4ee9..b45234f6339ad3979c20c763e99b218e2f11b8e0 100644
--- a/pkg/analysis_server/test/services/search/search_engine_test.dart
+++ b/pkg/analysis_server/test/services/search/search_engine_test.dart
@@ -163,6 +163,50 @@ class B {
expect(members, isNull);
}
+ test_membersOfSubtypes_private() async {
+ var a = _p('/test/a.dart');
+ var b = _p('/test/b.dart');
+
+ provider.newFile(
+ a,
+ '''
+class A {
+ void a() {}
+ void _b() {}
+ void _c() {}
+}
+class B extends A {
+ void _b() {}
+}
+''');
+ provider.newFile(
+ b,
+ '''
+import 'a.dart';
+class C extends A {
+ void a() {}
+ void _c() {}
+}
+class D extends B {
+ void _c() {}
+}
+''');
+
+ var driver1 = _newDriver();
+ var driver2 = _newDriver();
+
+ driver1.addFile(a);
+ driver2.addFile(b);
+ await scheduler.waitForIdle();
+
+ var resultA = await driver1.getResult(a);
+ ClassElement elementA = resultA.unit.element.types[0];
+
+ var searchEngine = new SearchEngineImpl([driver1, driver2]);
+ Set<String> members = await searchEngine.membersOfSubtypes(elementA);
+ expect(members, unorderedEquals(['a', '_b']));
+ }
+
test_searchAllSubtypes() async {
var p = _p('/test.dart');

Powered by Google App Engine
This is Rietveld 408576698