Issue 295923006: Fix underline position and thickness calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295923006: Fix underline position and thickness calculation (Closed)

Created:
6 years, 7 months ago by eae

Modified:
6 years, 7 months ago

Reviewers:
bungeman-chromium

CC:
blink-reviews, jamesr, krit, jbroman, abarth-chromium, danakj, dglazkov+blink, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Fix underline position and thickness calculation Use the underline offset and thickness data from the font when calculating the desired thickness and position. This depends on the Skia change https://codereview.chromium.org/271333002 which added the required fields. BUG=375454 R=bungeman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174431

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+545 lines, -7 lines)			Patch
M	LayoutTests/TestExpectations	View	1	2 chunks	+539 lines, -1 line	0 comments	Download
M	Source/platform/fonts/skia/SimpleFontDataSkia.cpp	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	public/blink_skia_config.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/295923006/20001

6 years, 7 months ago (2014-05-20 23:25:46 UTC) #4

Message was sent while issue was closed.

Change committed as 174431