Issue 271333002: Stage fixes for underline position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271333002: Stage fixes for underline position. (Closed)

Created:
6 years, 7 months ago by bungeman-skia

Modified:
6 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_FreeType.cpp	View		3 chunks	+15 lines, -0 lines	0 comments	Download
	M	src/ports/SkFontHost_win.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

bungeman-skia

These are fixes for underline position metrics. However, these changes need to be staged because ...

6 years, 7 months ago (2014-05-09 23:48:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/271333002/1

6 years, 7 months ago (2014-05-14 14:48:49 UTC) #4

Message was sent while issue was closed.

Change committed as 14726