Move base::WeakPtrFactory's ctor and dtor out-of-line

Move base::WeakPtrFactory's ctor and dtor out-of-line

They already invoke the out-of-line ctor/dtor for WeakReferenceOwner, so
inlining the bit that sets up ptr_ is not a performance improvement and costs
binary size.

Since WeakPtrFactory is a template, move the members into a non-template
base-class with the ctor/dtor out-of-line.

This is expected to reduce the binary size by ~4KB on Android and 24KB on x64 Linux.

BUG=728324
Review-Url: https://codereview.chromium.org/2959203002
Cr-Commit-Position: refs/heads/master@{#483139}
Committed: https://chromium.googlesource.com/chromium/src/+/d2a722f6bd23eaf0f791b19378c639dce6b3c2c0

[hans, 2017-06-28 17:30:16]

The CQ bit was checked by hans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 17:30:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 19:26:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 19:26:56]

Dry run: This issue passed the CQ dry run.

[hans, 2017-06-28 19:58:09]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2017-06-28 19:58:10]

Split out from https://codereview.chromium.org/2963623002/
Please take a look.

[Nico, 2017-06-28 20:48:19]

lgtm

[hans, 2017-06-28 21:06:11]

Description was changed from

==========
Move base::WeakPtrFactory's ctor and dtor out-of-line

They already invoke the out-of-line ctor/dtor for WeakReferenceOwner, so
inlining the bit that sets up ptr_ is not a performance improvement and costs
binary size.

Since WeakPtrFactory is a template, move the members into a non-template
base-class with the ctor/dtor out-of-line.

BUG=728324
==========

to

==========
Move base::WeakPtrFactory's ctor and dtor out-of-line

They already invoke the out-of-line ctor/dtor for WeakReferenceOwner, so
inlining the bit that sets up ptr_ is not a performance improvement and costs
binary size.

Since WeakPtrFactory is a template, move the members into a non-template
base-class with the ctor/dtor out-of-line.

This is expected to reduce the binary size by ~4KB on Android and 24KB on x64
Linux.

BUG=728324
==========

[hans, 2017-06-28 21:06:33]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:07:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 21:12:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498683993573100, "parent_rev":
"f9295c391265f2d6cf4e5c39e08102de6208e96b", "commit_rev":
"d2a722f6bd23eaf0f791b19378c639dce6b3c2c0"}

[commit-bot: I haz the power, 2017-06-28 21:13:14]

Description was changed from

==========
Move base::WeakPtrFactory's ctor and dtor out-of-line

They already invoke the out-of-line ctor/dtor for WeakReferenceOwner, so
inlining the bit that sets up ptr_ is not a performance improvement and costs
binary size.

Since WeakPtrFactory is a template, move the members into a non-template
base-class with the ctor/dtor out-of-line.

This is expected to reduce the binary size by ~4KB on Android and 24KB on x64
Linux.

BUG=728324
==========

to

==========
Move base::WeakPtrFactory's ctor and dtor out-of-line

They already invoke the out-of-line ctor/dtor for WeakReferenceOwner, so
inlining the bit that sets up ptr_ is not a performance improvement and costs
binary size.

Since WeakPtrFactory is a template, move the members into a non-template
base-class with the ctor/dtor out-of-line.

This is expected to reduce the binary size by ~4KB on Android and 24KB on x64
Linux.

BUG=728324

Review-Url: https://codereview.chromium.org/2959203002
Cr-Commit-Position: refs/heads/master@{#483139}
Committed:
https://chromium.googlesource.com/chromium/src/+/d2a722f6bd23eaf0f791b19378c6...
==========

[commit-bot: I haz the power, 2017-06-28 21:13:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2a722f6bd23eaf0f791b19378c6...