Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 2959133002: [Payment Request] unit tests for the FullCardRequester (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
jif
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] unit tests for the FullCardRequester BUG=602666 Review-Url: https://codereview.chromium.org/2959133002 Cr-Commit-Position: refs/heads/master@{#483085} Committed: https://chromium.googlesource.com/chromium/src/+/64aa81bc065af2bc2863486d40f21cc9dc81ea3e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -21 lines) Patch
M ios/chrome/browser/ui/payments/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/full_card_requester.h View 3 chunks +13 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/payments/full_card_requester.mm View 3 chunks +4 lines, -6 lines 0 comments Download
A ios/chrome/browser/ui/payments/full_card_requester_unittest.mm View 1 chunk +141 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.h View 3 chunks +2 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 3 chunks +4 lines, -1 line 1 comment Download
M ios/chrome/browser/ui/payments/payment_request_coordinator_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Moe
Hi JF, Please take a look.
3 years, 5 months ago (2017-06-28 03:13:38 UTC) #10
jif
lgtm https://codereview.chromium.org/2959133002/diff/40001/ios/chrome/browser/ui/payments/payment_request_coordinator.mm File ios/chrome/browser/ui/payments/payment_request_coordinator.mm (right): https://codereview.chromium.org/2959133002/diff/40001/ios/chrome/browser/ui/payments/payment_request_coordinator.mm#newcode126 ios/chrome/browser/ui/payments/payment_request_coordinator.mm:126: #pragma mark - FullCardRequesterConsumer Thanks for adding those, ...
3 years, 5 months ago (2017-06-28 16:30:15 UTC) #11
Moe
On 2017/06/28 at 16:30:15, jif wrote: > lgtm > > https://codereview.chromium.org/2959133002/diff/40001/ios/chrome/browser/ui/payments/payment_request_coordinator.mm > File ios/chrome/browser/ui/payments/payment_request_coordinator.mm (right): ...
3 years, 5 months ago (2017-06-28 17:03:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959133002/40001
3 years, 5 months ago (2017-06-28 17:03:49 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 18:57:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/64aa81bc065af2bc2863486d40f2...

Powered by Google App Engine
This is Rietveld 408576698