Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 295913009: Allow specifying base offset when constructing Keyed hydrogen instructions (Closed)

Created:
6 years, 7 months ago by danno
Modified:
6 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Allow specifying base offset when constructing Keyed hydrogen instructions This is preparation for pending hydrogen stub work that needs to access memory using KeyedLoad/KeyedStore operations where the base offset used for the accesses are is the the default (e.g. the size of an FixedArray header for FixedArrays or zero for external arrays). R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21426

Patch Set 1 #

Patch Set 2 : Ports to x64 and ARM #

Patch Set 3 : ARM fixes #

Patch Set 4 : Fix ARM #

Patch Set 5 : arm64 patch #

Patch Set 6 : Implement arm64 #

Patch Set 7 : Remove unnecessary changes #

Patch Set 8 : Remove more unnecessary code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -211 lines) Patch
M src/arm/lithium-arm.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 7 14 chunks +27 lines, -62 lines 0 comments Download
M src/arm64/lithium-arm64.h View 1 2 3 4 2 chunks +7 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 5 10 chunks +28 lines, -38 lines 0 comments Download
M src/elements-kind.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/elements-kind.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/hydrogen-dehoist.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 13 chunks +52 lines, -22 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 10 chunks +11 lines, -24 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 13 chunks +14 lines, -34 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
6 years, 7 months ago (2014-05-22 08:17:23 UTC) #1
mvstanton
Looks very straightforward. LGTM.
6 years, 7 months ago (2014-05-22 08:32:21 UTC) #2
danno
6 years, 7 months ago (2014-05-22 08:38:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #8 manually as r21426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698