OLD | NEW |
1 // Copyright 2013 the V8 project authors. All rights reserved. | 1 // Copyright 2013 the V8 project authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "hydrogen-dehoist.h" | 5 #include "hydrogen-dehoist.h" |
6 | 6 |
7 namespace v8 { | 7 namespace v8 { |
8 namespace internal { | 8 namespace internal { |
9 | 9 |
10 static void DehoistArrayIndex(ArrayInstructionInterface* array_operation) { | 10 static void DehoistArrayIndex(ArrayInstructionInterface* array_operation) { |
(...skipping 12 matching lines...) Expand all Loading... |
23 constant = HConstant::cast(binary_operation->right()); | 23 constant = HConstant::cast(binary_operation->right()); |
24 } else { | 24 } else { |
25 return; | 25 return; |
26 } | 26 } |
27 | 27 |
28 if (!constant->HasInteger32Value()) return; | 28 if (!constant->HasInteger32Value()) return; |
29 int32_t sign = binary_operation->IsSub() ? -1 : 1; | 29 int32_t sign = binary_operation->IsSub() ? -1 : 1; |
30 int32_t value = constant->Integer32Value() * sign; | 30 int32_t value = constant->Integer32Value() * sign; |
31 // We limit offset values to 30 bits because we want to avoid the risk of | 31 // We limit offset values to 30 bits because we want to avoid the risk of |
32 // overflows when the offset is added to the object header size. | 32 // overflows when the offset is added to the object header size. |
33 if (value >= 1 << array_operation->MaxIndexOffsetBits() || value < 0) return; | 33 if (value >= 1 << array_operation->MaxBaseOffsetBits() || value < 0) return; |
34 array_operation->SetKey(subexpression); | 34 array_operation->SetKey(subexpression); |
35 if (binary_operation->HasNoUses()) { | 35 if (binary_operation->HasNoUses()) { |
36 binary_operation->DeleteAndReplaceWith(NULL); | 36 binary_operation->DeleteAndReplaceWith(NULL); |
37 } | 37 } |
38 array_operation->SetIndexOffset(static_cast<uint32_t>(value)); | 38 value <<= ElementsKindToShiftSize(array_operation->elements_kind()); |
| 39 array_operation->IncreaseBaseOffset(static_cast<uint32_t>(value)); |
39 array_operation->SetDehoisted(true); | 40 array_operation->SetDehoisted(true); |
40 } | 41 } |
41 | 42 |
42 | 43 |
43 void HDehoistIndexComputationsPhase::Run() { | 44 void HDehoistIndexComputationsPhase::Run() { |
44 const ZoneList<HBasicBlock*>* blocks(graph()->blocks()); | 45 const ZoneList<HBasicBlock*>* blocks(graph()->blocks()); |
45 for (int i = 0; i < blocks->length(); ++i) { | 46 for (int i = 0; i < blocks->length(); ++i) { |
46 for (HInstructionIterator it(blocks->at(i)); !it.Done(); it.Advance()) { | 47 for (HInstructionIterator it(blocks->at(i)); !it.Done(); it.Advance()) { |
47 HInstruction* instr = it.Current(); | 48 HInstruction* instr = it.Current(); |
48 if (instr->IsLoadKeyed()) { | 49 if (instr->IsLoadKeyed()) { |
49 DehoistArrayIndex(HLoadKeyed::cast(instr)); | 50 DehoistArrayIndex(HLoadKeyed::cast(instr)); |
50 } else if (instr->IsStoreKeyed()) { | 51 } else if (instr->IsStoreKeyed()) { |
51 DehoistArrayIndex(HStoreKeyed::cast(instr)); | 52 DehoistArrayIndex(HStoreKeyed::cast(instr)); |
52 } | 53 } |
53 } | 54 } |
54 } | 55 } |
55 } | 56 } |
56 | 57 |
57 } } // namespace v8::internal | 58 } } // namespace v8::internal |
OLD | NEW |