android: Use fdebug-info-for-profiling in minimal_symbols mode (the default).

android: Use fdebug-info-for-profiling in minimal_symbols mode (the default).

We build chrome with -g1 on Android, because with -g2 binary size exceeds
the 32-bit ELF container format.  However, in -g1 mode clang doesn't emit
DW_AT_linkage_name annotations, so we don't get qualified names in stacks.

As a workaround, pass fdebug-info-for-profiling which enables
DW_AT_linkage_name and a few other things we don't need.

This increases the size of unstripped libchrome.so from 400MB to 600MB,
which is quite a bit larger, but still comfortably below the limit.

BUG=735027
Review-Url: https://codereview.chromium.org/2959083002
Cr-Commit-Position: refs/heads/master@{#482772}
Committed: https://chromium.googlesource.com/chromium/src/+/120b37effd521f42b59184bb0abc9d8cebcafc0d

[Nico, 2017-06-27 19:54:21]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-06-27 19:54:30]

thakis@chromium.org changed reviewers:
+ torne@chromium.org

[commit-bot: I haz the power, 2017-06-27 19:54:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Torne, 2017-06-27 20:00:05]

lgtm

[Nico, 2017-06-27 20:00:41]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-06-27 20:00:43]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-06-27 20:00:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:51:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498593643809780, "parent_rev":
"71fd419f15a9fb890a6d01262efc88cdba086661", "commit_rev":
"120b37effd521f42b59184bb0abc9d8cebcafc0d"}

[commit-bot: I haz the power, 2017-06-27 22:51:33]

Description was changed from

==========
android: Use fdebug-info-for-profiling in minimal_symbols mode (the default).

We build chrome with -g1 on Android, because with -g2 binary size exceeds
the 32-bit ELF container format.  However, in -g1 mode clang doesn't emit
DW_AT_linkage_name annotations, so we don't get qualified names in stacks.

As a workaround, pass fdebug-info-for-profiling which enables
DW_AT_linkage_name and a few other things we don't need.

This increases the size of unstripped libchrome.so from 400MB to 600MB,
which is quite a bit larger, but still comfortably below the limit.

BUG=735027
==========

to

==========
android: Use fdebug-info-for-profiling in minimal_symbols mode (the default).

We build chrome with -g1 on Android, because with -g2 binary size exceeds
the 32-bit ELF container format.  However, in -g1 mode clang doesn't emit
DW_AT_linkage_name annotations, so we don't get qualified names in stacks.

As a workaround, pass fdebug-info-for-profiling which enables
DW_AT_linkage_name and a few other things we don't need.

This increases the size of unstripped libchrome.so from 400MB to 600MB,
which is quite a bit larger, but still comfortably below the limit.

BUG=735027

Review-Url: https://codereview.chromium.org/2959083002
Cr-Commit-Position: refs/heads/master@{#482772}
Committed:
https://chromium.googlesource.com/chromium/src/+/120b37effd521f42b59184bb0abc...
==========

[commit-bot: I haz the power, 2017-06-27 22:51:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/120b37effd521f42b59184bb0abc...