Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2959023004: [Payment Request] Invalidates the update Payment Summary item timer on stop (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
macourteau
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Invalidates the update Payment Summary item timer on stop If the timer is not invalidated on PaymentRequestCoordinator's -stop, it may try to update the item well after the payment has succeeded. BUG=602666 Review-Url: https://codereview.chromium.org/2959023004 Cr-Commit-Position: refs/heads/master@{#483095} Committed: https://chromium.googlesource.com/chromium/src/+/e890d879c5d52e4776bf102d63476f3fbee6e9ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Moe
Hi MAC, Please take a look.
3 years, 5 months ago (2017-06-28 17:59:47 UTC) #2
macourteau
lgtm
3 years, 5 months ago (2017-06-28 18:33:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2959023004/1
3 years, 5 months ago (2017-06-28 18:34:00 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 19:17:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e890d879c5d52e4776bf102d6347...

Powered by Google App Engine
This is Rietveld 408576698