Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 2958973003: Add exception prediction for ArrayForEachLoopLazyDeoptContinuation (Closed)

Created:
3 years, 5 months ago by danno
Modified:
3 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Add exception prediction for ArrayForEachLoopLazyDeoptContinuation BUG=v8:6526 Review-Url: https://codereview.chromium.org/2958973003 Cr-Commit-Position: refs/heads/master@{#46276} Committed: https://chromium.googlesource.com/v8/v8/+/a49c5fd1e3cbe80716a33b87d77b353c64d27718

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed test per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/builtins/builtins-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/debugger/regress/regress-6526.js View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
danno
PTAL
3 years, 5 months ago (2017-06-27 15:55:43 UTC) #2
jgruber
lgtm, thanks! https://codereview.chromium.org/2958973003/diff/1/test/mjsunit/regress/regress-6526.js File test/mjsunit/regress/regress-6526.js (right): https://codereview.chromium.org/2958973003/diff/1/test/mjsunit/regress/regress-6526.js#newcode5 test/mjsunit/regress/regress-6526.js:5: // Flags: --enable-inspector --allow-natives-syntax This test should ...
3 years, 5 months ago (2017-06-28 09:10:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958973003/20001
3 years, 5 months ago (2017-06-28 10:35:52 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 10:37:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a49c5fd1e3cbe80716a33b87d77b353c64d...

Powered by Google App Engine
This is Rietveld 408576698