Add ripple effect to action buttons in new-style notification.

Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. The padding is also adjusted.

BUG=726242
TEST=manual

Review-Url: https://codereview.chromium.org/2958963002
Cr-Commit-Position: refs/heads/master@{#483335}
Committed: https://chromium.googlesource.com/chromium/src/+/b9776accebbf3a0e8a2a5abfe8f844d532bc65df

[tetsui, 2017-06-27 07:00:07]

Description was changed from

==========
Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. Padding is also adjusted.

BUG=726242
TEST=manual
==========

to

==========
Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. The padding is also adjusted.

BUG=726242
TEST=manual
==========

[tetsui, 2017-06-27 07:00:21]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 07:00:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tetsui, 2017-06-27 07:02:54]

tetsui@chromium.org changed reviewers:
+ fukino@chromium.org, yoshiki@chromium.org

[tetsui, 2017-06-27 07:02:55]

Please take a look. Thanks!

[commit-bot: I haz the power, 2017-06-27 08:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 08:12:03]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tetsui, 2017-06-27 08:14:09]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 08:14:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 09:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 09:27:32]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-06-28 02:11:58]

https://codereview.chromium.org/2958963002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2958963002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.cc:693: // mock. Investigate how to
set hover color and ripple color separately.
(record from offline discussion) As this change is not urgent, could you
investigate how the inkdrop effect and hover color works?

[tetsui, 2017-06-28 06:30:13]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 06:30:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tetsui, 2017-06-28 06:30:24]

https://codereview.chromium.org/2958963002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2958963002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.cc:693: // mock. Investigate how to
set hover color and ripple color separately.
On 2017/06/28 02:11:57, fukino wrote:
> (record from offline discussion) As this change is not urgent, could you
> investigate how the inkdrop effect and hover color works?

Done. Hover color is precisely accurate. Ripple color is slightly different from
the mock, but I think the original mock RGB color might not be accurate here.
(It depends on alpha blend formula? gamma? I'm not familiar with them...)

Ripple color in mock: #CFCFCF
Ripple color in the implementation: #CACACA
Manual calculation: 0xee * (1-0.08) * (1-0.08) = #C9C9C9

[commit-bot: I haz the power, 2017-06-28 07:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 07:30:12]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-06-29 04:11:03]

lgtm with a nit.

https://codereview.chromium.org/2958963002/diff/20001/ui/message_center/views...
File ui/message_center/views/notification_view_md.h (right):

https://codereview.chromium.org/2958963002/diff/20001/ui/message_center/views...
ui/message_center/views/notification_view_md.h:107:
std::vector<NotificationButtonMD*> action_buttons_;
We can still keep the type as views::LabelButton* in this header.

[tetsui, 2017-06-29 04:22:13]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 04:22:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tetsui, 2017-06-29 04:23:11]

fukino@: Thank you for reviewing!
yoshiki@: PTAL for OWNERS review. Thank you!

https://codereview.chromium.org/2958963002/diff/20001/ui/message_center/views...
File ui/message_center/views/notification_view_md.h (right):

https://codereview.chromium.org/2958963002/diff/20001/ui/message_center/views...
ui/message_center/views/notification_view_md.h:107:
std::vector<NotificationButtonMD*> action_buttons_;
On 2017/06/29 04:11:03, fukino wrote:
> We can still keep the type as views::LabelButton* in this header.

Done.

[yoshiki, 2017-06-29 04:35:04]

lgtm with cosmetic nits

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
ui/message_center/views/notification_view_md.cc:306:
NotificationButtonMD::CreateInkDropHighlight() const {
Please move this below the dtor to match the order in the class definition.

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
ui/message_center/views/notification_view_md.cc:313:
NotificationButtonMD::~NotificationButtonMD() {}
please specify the default destructor: "~NotificationButtonMD() = default".

[tetsui, 2017-06-29 04:39:34]

yoshiki@: Thank you!

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
ui/message_center/views/notification_view_md.cc:306:
NotificationButtonMD::CreateInkDropHighlight() const {
On 2017/06/29 04:35:03, yoshiki wrote:
> Please move this below the dtor to match the order in the class definition.

Done.

https://codereview.chromium.org/2958963002/diff/40001/ui/message_center/views...
ui/message_center/views/notification_view_md.cc:313:
NotificationButtonMD::~NotificationButtonMD() {}
On 2017/06/29 04:35:04, yoshiki wrote:
> please specify the default destructor: "~NotificationButtonMD() = default".

Done.

[tetsui, 2017-06-29 04:39:53]

The CQ bit was checked by tetsui@chromium.org

[tetsui, 2017-06-29 04:39:54]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org,
yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2958963002/#ps60001
(title: "Resolve review comments.")

[commit-bot: I haz the power, 2017-06-29 04:40:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 05:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 05:44:47]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tetsui, 2017-06-29 06:23:35]

The CQ bit was checked by tetsui@chromium.org

[commit-bot: I haz the power, 2017-06-29 06:23:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 07:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 07:49:59]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tetsui, 2017-06-29 11:41:51]

The CQ bit was checked by tetsui@chromium.org

[commit-bot: I haz the power, 2017-06-29 11:41:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 12:32:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498736511910490,
"parent_rev": "db1cd66d68fea5ff95c359401f440043a7d2dedc", "commit_rev":
"b9776accebbf3a0e8a2a5abfe8f844d532bc65df"}

[commit-bot: I haz the power, 2017-06-29 12:33:03]

Description was changed from

==========
Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. The padding is also adjusted.

BUG=726242
TEST=manual
==========

to

==========
Add ripple effect to action buttons in new-style notification.

Hover background color and ripple effect are added to action buttons in
new-style notification. The padding is also adjusted.

BUG=726242
TEST=manual

Review-Url: https://codereview.chromium.org/2958963002
Cr-Commit-Position: refs/heads/master@{#483335}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9776accebbf3a0e8a2a5abfe8f8...
==========

[commit-bot: I haz the power, 2017-06-29 12:33:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b9776accebbf3a0e8a2a5abfe8f8...