Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2958893002: Remove references (in comments only) to FILE thread in protocol handlers (Closed)

Created:
3 years, 5 months ago by benwells
Modified:
3 years, 5 months ago
Reviewers:
fdoray
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references (in comments only) to FILE thread in protocol handlers The updated test file had out of date comments. BUG=689520 Review-Url: https://codereview.chromium.org/2958893002 Cr-Commit-Position: refs/heads/master@{#482793} Committed: https://chromium.googlesource.com/chromium/src/+/2de6db7a01ddc5dcefedd39a76cf95c83020d032

Patch Set 1 #

Patch Set 2 : Actually just remove the whole comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benwells
Sorry if I'm being dumb - is this all that is needed to convert this ...
3 years, 5 months ago (2017-06-27 00:47:06 UTC) #2
fdoray
On 2017/06/27 00:47:06, benwells wrote: > Sorry if I'm being dumb - is this all ...
3 years, 5 months ago (2017-06-27 13:17:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958893002/20001
3 years, 5 months ago (2017-06-27 22:59:02 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 23:38:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2de6db7a01ddc5dcefedd39a76cf...

Powered by Google App Engine
This is Rietveld 408576698