Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2958873002: [Payment Request] Unit tests for incomplete shipping/billing address selection (Closed)

Created:
3 years, 5 months ago by Moe
Modified:
3 years, 5 months ago
Reviewers:
macourteau
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, mahmadi+paymentswatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Unit tests for incomplete shipping/billing address selection BUG=602666 Review-Url: https://codereview.chromium.org/2958873002 Cr-Commit-Position: refs/heads/master@{#482664} Committed: https://chromium.googlesource.com/chromium/src/+/a97593a731f5139d638539514b042fc5b962ef21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -25 lines) Patch
M ios/chrome/browser/payments/test_payment_request.h View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/test_payment_request.mm View 1 chunk +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/billing_address_selection_coordinator_unittest.mm View 6 chunks +40 lines, -11 lines 0 comments Download
M ios/chrome/browser/ui/payments/shipping_address_selection_coordinator_unittest.mm View 5 chunks +40 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Moe
Hi MAC, Please take a look.
3 years, 5 months ago (2017-06-26 23:41:37 UTC) #4
macourteau
lgtm
3 years, 5 months ago (2017-06-27 15:35:49 UTC) #7
Moe
Thank you.
3 years, 5 months ago (2017-06-27 17:23:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958873002/1
3 years, 5 months ago (2017-06-27 17:23:48 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 17:27:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a97593a731f5139d638539514b04...

Powered by Google App Engine
This is Rietveld 408576698