Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2958853002: Propagate name of system service account to the bot. (Closed)

Created:
3 years, 5 months ago by Vadim Sh.
Modified:
3 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Propagate name of system service account to the bot. So it can (in later CLs) setup LUCI_CONTEXT that has this account enabled ( if it is indeed enabled). R=iannucci@chromium.org BUG=730878 Review-Url: https://codereview.chromium.org/2958853002 Committed: https://github.com/luci/luci-py/commit/93c2cd911054658150e1a4009bd19790d06ea62a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -22 lines) Patch
M appengine/swarming/handlers_bot.py View 3 chunks +17 lines, -3 lines 0 comments Download
M appengine/swarming/handlers_bot_test.py View 5 chunks +20 lines, -5 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_auth.py View 4 chunks +37 lines, -12 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_auth_test.py View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/bot_main_test.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Vadim Sh.
PTAL A bit of plumbing. Bots needs to know what system service account (if any) ...
3 years, 5 months ago (2017-06-26 23:01:49 UTC) #1
Vadim Sh.
If you are wondering about use of 'none': it all eventually comes from Datastore's inability ...
3 years, 5 months ago (2017-06-26 23:05:49 UTC) #4
iannucci
lgtm
3 years, 5 months ago (2017-06-26 23:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958853002/1
3 years, 5 months ago (2017-06-26 23:14:05 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 23:22:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/93c2cd911054658150e1a4009bd19790d06ea62a

Powered by Google App Engine
This is Rietveld 408576698