Settings: Network: Specify a default IPCofig when not set

Settings: Network: Specify a default IPCofig when not set

This prevents an invalid static setting with empty values, and
fixes the logic to send an update any time the 'automatic'
setting is toggled.

BUG=733848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2958833002
Cr-Commit-Position: refs/heads/master@{#482444}
Committed: https://chromium.googlesource.com/chromium/src/+/aff0615b647e2250ae368dc8a808e615fba4e3e8

[stevenjb, 2017-06-26 21:01:35]

Description was changed from

==========
Settings: Network: Specify a default IPCofig when not set

This prevents an invalid static setting with empty values, and
fixes the logic to send an update any time the 'automatic'
setting is toggled.

BUG=733848
==========

to

==========
Settings: Network: Specify a default IPCofig when not set

This prevents an invalid static setting with empty values, and
fixes the logic to send an update any time the 'automatic'
setting is toggled.

BUG=733848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-06-26 21:04:57]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org, tbarzic@chromium.org

[stevenjb, 2017-06-26 21:04:57]

IP configuration UI is kind of subtle / complicated. Normally when a DHCP server
is available, Shill will always provide an IPConfigs property, however if no
DHCP server is available (e.g. setting up a local network using static IP
addresses), no such property will be provided so we need to make sure to create
and set one when the toggle is switched.

[michaelpg, 2017-06-26 21:16:29]

lgtm

Yeah this is tricky. I see another potential fix that fires ip-change if (and
only if) all the textboxes have valid values, but that looks more complicated
(and maybe specifying defaults is a better experience anyway)

[stevenjb, 2017-06-26 21:23:42]

On 2017/06/26 21:16:29, michaelpg wrote:
> lgtm
> 
> Yeah this is tricky. I see another potential fix that fires ip-change if (and
> only if) all the textboxes have valid values, but that looks more complicated
> (and maybe specifying defaults is a better experience anyway)

Yeah, I went with a common default because I do think it is a better experience.
If nothing else it provides formatting for each field.

[stevenjb, 2017-06-26 21:23:44]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:24:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 22:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498512224712860, "parent_rev":
"b037d8aeab84570a38de96ea8a7f4fe314f8e5a1", "commit_rev":
"aff0615b647e2250ae368dc8a808e615fba4e3e8"}

[commit-bot: I haz the power, 2017-06-26 22:50:43]

Description was changed from

==========
Settings: Network: Specify a default IPCofig when not set

This prevents an invalid static setting with empty values, and
fixes the logic to send an update any time the 'automatic'
setting is toggled.

BUG=733848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Specify a default IPCofig when not set

This prevents an invalid static setting with empty values, and
fixes the logic to send an update any time the 'automatic'
setting is toggled.

BUG=733848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2958833002
Cr-Commit-Position: refs/heads/master@{#482444}
Committed:
https://chromium.googlesource.com/chromium/src/+/aff0615b647e2250ae368dc8a808...
==========

[commit-bot: I haz the power, 2017-06-26 22:50:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aff0615b647e2250ae368dc8a808...