Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2958763002: Disable WebRtcMediaRecorderTest.IllegalPauseThrowsDOMError on TSan (Closed)

Created:
3 years, 5 months ago by msramek
Modified:
3 years, 5 months ago
Reviewers:
xidachen
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebRtcMediaRecorderTest.IllegalPauseThrowsDOMError on TSan ...since it's flaky. This is a followup to https://chromium-review.googlesource.com/548655 which disabled WebRtcMediaRecorderTest.IllegalRequestDataThrowsDOMError from the same test suite. NOTRY=True TBR=xidachen@chromium.org BUG=736268 Review-Url: https://codereview.chromium.org/2958763002 Cr-Commit-Position: refs/heads/master@{#482258} Committed: https://chromium.googlesource.com/chromium/src/+/32cc6efa4149f3dac7f4853ec2a698ae24a8a53f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
msramek
3 years, 5 months ago (2017-06-26 13:41:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958763002/1
3 years, 5 months ago (2017-06-26 13:42:53 UTC) #3
xidachen
lgtm I think it should be safe to put NOTRY=true
3 years, 5 months ago (2017-06-26 13:43:37 UTC) #4
msramek
On 2017/06/26 13:43:37, xidachen wrote: > lgtm > > I think it should be safe ...
3 years, 5 months ago (2017-06-26 13:44:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958763002/1
3 years, 5 months ago (2017-06-26 13:44:30 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 13:51:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32cc6efa4149f3dac7f4853ec2a6...

Powered by Google App Engine
This is Rietveld 408576698