Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2958663002:
[MediaRouter] PresentationServiceDelegateImpl cleanup. (Closed)
Description[MediaRouter] PresentationServiceDelegateImpl cleanup.
- Removed method declarations that are not defined.
- Removed PresentationFrameManager. There is not much reason to keep
it since most of the logic is just delegating from PSDImpl.
- Push the URL validity check for screen availability to PSImpl.
BUG=736557
Review-Url: https://codereview.chromium.org/2958663002
Cr-Commit-Position: refs/heads/master@{#485437}
Committed: https://chromium.googlesource.com/chromium/src/+/f23b896efce3a6ea139d29efd791bc09974def9f
Patch Set 1 #
Total comments: 6
Patch Set 2 : rebase #Patch Set 3 : Addressed Bin's comments #
Total comments: 10
Patch Set 4 : Addressed Kevin's comments #Patch Set 5 : rebase #
Messages
Total messages: 27 (13 generated)
The CQ bit was checked by imcheng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [MediaRouter] PresentationServiceDelegateImpl cleanup. - Removed method declarations that are not defined. - Removed PresentationFrameManager. There is not much reason to keep it since most of the logic is just delegating from PSDImpl. - Push the URL validity check for screen availability to PSImpl. BUG= ========== to ========== [MediaRouter] PresentationServiceDelegateImpl cleanup. - Removed method declarations that are not defined. - Removed PresentationFrameManager. There is not much reason to keep it since most of the logic is just delegating from PSDImpl. - Push the URL validity check for screen availability to PSImpl. BUG=736557 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
imcheng@chromium.org changed reviewers: + zhaobin@chromium.org
Bin: PTAL thanks!
Friendly ping Bin :) Per discussion last week, we can simplify PSDImpl a bit further by having PSImpl interact directly with PresentationFrames. I would like to do that in a separate patch.
https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... File chrome/browser/media/router/presentation_service_delegate_impl.cc (right): https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:379: ClearDefaultPresentationRequest(); nit: return here so we do not need else? https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:451: const std::string& presentation_id) { Shall we change parameter order here as well to be consistent with PresentationFrame::RemovePresentation()? https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:454: it->second->RemovePresentation(route_id, presentation_id); Shall we change order of parameter to RemovePresentation(presentation_id, route_id)?
https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... File chrome/browser/media/router/presentation_service_delegate_impl.cc (right): https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:379: ClearDefaultPresentationRequest(); On 2017/07/05 23:18:10, zhaobin wrote: > nit: return here so we do not need else? Done. https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:451: const std::string& presentation_id) { On 2017/07/05 23:18:10, zhaobin wrote: > Shall we change parameter order here as well to be consistent with > PresentationFrame::RemovePresentation()? Good catch. I removed the route_id parameter since it can be derived from presentation_id. https://codereview.chromium.org/2958663002/diff/1/chrome/browser/media/router... chrome/browser/media/router/presentation_service_delegate_impl.cc:454: it->second->RemovePresentation(route_id, presentation_id); On 2017/07/05 23:18:10, zhaobin wrote: > Shall we change order of parameter to RemovePresentation(presentation_id, > route_id)? Done.
lgtm
lgtm
imcheng@chromium.org changed reviewers: + kmarshall@chromium.org
Kevin, can you PTAL?
lgtm Really minor comment nits https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... File chrome/browser/media/router/presentation_service_delegate_impl.cc (right): https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.cc:77: // Instances are created when certain Presentation API is invoked on a frame, lazily created https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... File chrome/browser/media/router/presentation_service_delegate_impl.h (right): https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:231: bool IsMainFrame(const RenderFrameHostId& render_frame_host_id) const; Add a comment for all new methods? https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:246: // References to the observers listening for changes to this tab WebContent's The pluralized WebContents name makes a mess of things here... "the default presentation of this tab's WebContents"? https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:251: // Default presentation request for the owning tab WebContents. tab's https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:254: // Callback to invoke when default presentation has started. the default presentation
Thanks Kevin! https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... File chrome/browser/media/router/presentation_service_delegate_impl.cc (right): https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.cc:77: // Instances are created when certain Presentation API is invoked on a frame, On 2017/07/10 19:01:36, Kevin M wrote: > lazily created Done. https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... File chrome/browser/media/router/presentation_service_delegate_impl.h (right): https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:231: bool IsMainFrame(const RenderFrameHostId& render_frame_host_id) const; On 2017/07/10 19:01:36, Kevin M wrote: > Add a comment for all new methods? Done. https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:246: // References to the observers listening for changes to this tab WebContent's On 2017/07/10 19:01:37, Kevin M wrote: > The pluralized WebContents name makes a mess of things here... > > "the default presentation of this tab's WebContents"? Done. https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:251: // Default presentation request for the owning tab WebContents. On 2017/07/10 19:01:36, Kevin M wrote: > tab's Done. Got rid of tab, since it means the same thing as WebContents in this context. https://codereview.chromium.org/2958663002/diff/40001/chrome/browser/media/ro... chrome/browser/media/router/presentation_service_delegate_impl.h:254: // Callback to invoke when default presentation has started. On 2017/07/10 19:01:36, Kevin M wrote: > the default presentation Done.
The CQ bit was checked by imcheng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kmarshall@chromium.org, zhaobin@chromium.org Link to the patchset: https://codereview.chromium.org/2958663002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by imcheng@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499724776057960,
"parent_rev": "2f6a4c5bdc43727b8ec3820398cee35201a70edf", "commit_rev":
"f23b896efce3a6ea139d29efd791bc09974def9f"}
Message was sent while issue was closed.
Description was changed from ========== [MediaRouter] PresentationServiceDelegateImpl cleanup. - Removed method declarations that are not defined. - Removed PresentationFrameManager. There is not much reason to keep it since most of the logic is just delegating from PSDImpl. - Push the URL validity check for screen availability to PSImpl. BUG=736557 ========== to ========== [MediaRouter] PresentationServiceDelegateImpl cleanup. - Removed method declarations that are not defined. - Removed PresentationFrameManager. There is not much reason to keep it since most of the logic is just delegating from PSDImpl. - Push the URL validity check for screen availability to PSImpl. BUG=736557 Review-Url: https://codereview.chromium.org/2958663002 Cr-Commit-Position: refs/heads/master@{#485437} Committed: https://chromium.googlesource.com/chromium/src/+/f23b896efce3a6ea139d29efd791... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/f23b896efce3a6ea139d29efd791... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
