Chromium Code Reviews Chromium Code Reviews
Issue
2958563002:
Revert "Disable the buggy RSA parser by default." (Closed)
DescriptionRevert "Disable the buggy RSA parser by default."
This reverts commit 2878e36f5fea9a7404ffd0ab7b4be83d035d199a.
Reason for revert: This is checking for a feature before FeatureList::InitializeInstance is called, causing a crash at startup; see https://crbug.com/736251.
Original change's description:
> Disable the buggy RSA parser by default.
>
> In doing so, fix the error mapping in openssl_ssl_util.cc. An SSL
> connection may fail due to errors in other modules as well (notably the
> RSA parser lives in libcrypto). Map any unknown error to
> ERR_SSL_PROTOCOL_ERROR, rather than ERR_FAILED and continue to
> report the error info.
>
> Bug: 735616
> Change-Id: Icb587e66987ddd9d5445d30d456de1c029cda21a
> Reviewed-on: https://chromium-review.googlesource.com/540536
> Commit-Queue: Steven Valdez <svaldez@chromium.org>;
> Reviewed-by: Steven Valdez <svaldez@chromium.org>;
> Cr-Commit-Position: refs/heads/master@{#481640}
TBR=davidben@chromium.org,svaldez@chromium.org
Change-Id: If7f24fa8a99bfd7a8daa2efad926b06350d5d9a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 735616
Reviewed-on: https://chromium-review.googlesource.com/545715
Reviewed-by: Greg Thompson <grt@chromium.org>;
Commit-Queue: Greg Thompson <grt@chromium.org>;
Cr-Original-Commit-Position: refs/heads/master@{#481877}
Review-Url: https://codereview.chromium.org/2958563002 .
Cr-Commit-Position: refs/branch-heads/3139@{#1}
Cr-Branched-From: 2dd0ea84298d45e0962c595c591529bc84dd0ebd-refs/heads/master@{#481757}
Committed: https://chromium.googlesource.com/chromium/src/+/b576541bed6393420b4d2c2919ff0d673efa4622
Patch Set 1 #
Messages
Total messages: 3 (1 generated)
|
||||||||||||||||||||||||||||
