Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2958553002: Sort type tests. (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Sort type tests. - and match sorting of injected members with patched_dart2js_sdk in test R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/52f1f25d344dc5023f4dc03e5d33ba9e4c170e32

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -10 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 2 2 chunks +25 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 8 chunks +52 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-23 14:01:06 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2958553002/diff/20001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (right): https://codereview.chromium.org/2958553002/diff/20001/pkg/compiler/lib/src/elements/elements.dart#newcode652 pkg/compiler/lib/src/elements/elements.dart:652: static bool usePatchedDart2jsSdkSorting = false; +TODO - delete ...
3 years, 6 months ago (2017-06-23 20:36:34 UTC) #3
Johnni Winther
https://codereview.chromium.org/2958553002/diff/20001/pkg/compiler/lib/src/elements/elements.dart File pkg/compiler/lib/src/elements/elements.dart (right): https://codereview.chromium.org/2958553002/diff/20001/pkg/compiler/lib/src/elements/elements.dart#newcode652 pkg/compiler/lib/src/elements/elements.dart:652: static bool usePatchedDart2jsSdkSorting = false; On 2017/06/23 20:36:34, Siggi ...
3 years, 5 months ago (2017-06-26 10:15:09 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-06-26 10:20:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
52f1f25d344dc5023f4dc03e5d33ba9e4c170e32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698