Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2958503002: Enable feature to load icons from Web Manifests by defaut (Closed)

Created:
3 years, 6 months ago by mastiz
Modified:
3 years, 6 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, browser-components-watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable feature to load icons from Web Manifests by defaut This causes Web Manifest icons to be read during page load, to improve coverage for UIs demanding large icons like the NTP. We've exercised the code in dev and everything looks good enough to enable by default (modulo two bugs we already have a fix for). Leads are commited to improving support for Web Manifests, so it's quite likely that the feature can be launched in M61. BUG=711187 Review-Url: https://codereview.chromium.org/2958503002 Cr-Commit-Position: refs/heads/master@{#481962} Committed: https://chromium.googlesource.com/chromium/src/+/b33135b2510cfac895ebe304cecb759b621c2d3c

Patch Set 1 #

Patch Set 2 : Update unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M chrome/browser/favicon/content_favicon_driver_browsertest.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M components/favicon/core/favicon_handler_unittest.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download
M components/favicon/core/features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
mastiz
3 years, 6 months ago (2017-06-23 10:10:20 UTC) #4
pkotwicz
LGTM
3 years, 6 months ago (2017-06-23 17:56:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958503002/20001
3 years, 6 months ago (2017-06-23 18:13:35 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 18:19:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b33135b2510cfac895ebe304cecb...

Powered by Google App Engine
This is Rietveld 408576698