Stop the banner pipeline from being triggered if it is already active.

Stop the banner pipeline from being triggered if it is already active.

This is a speculative fix for crbug.com/736045. If we tip over the
engagement threshold while the app banner pipeline is active, and we've
already started the banenr checking due to the onload experiment, we
could get into a state where RequestAppBanner is called but we haven't
stopped the previous run.

This CL guards all calls to RequestAppBanner on the banner pipeline not
being active.

BUG=736045
Review-Url: https://codereview.chromium.org/2958473002
Cr-Commit-Position: refs/heads/master@{#482103}
Committed: https://chromium.googlesource.com/chromium/src/+/339d7dc9d0e5c64329105314a52413025b18b89c

[dominickn, 2017-06-23 04:28:23]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-06-23 04:28:41]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2017-06-23 04:28:42]

PTAL, thanks

[commit-bot: I haz the power, 2017-06-23 04:28:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 04:42:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 04:42:46]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[benwells, 2017-06-23 05:00:43]

lgtm

[dominickn, 2017-06-23 05:09:10]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:09:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 05:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:22:32]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dominickn, 2017-06-23 05:23:15]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:23:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 05:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:38:28]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dominickn, 2017-06-23 05:50:43]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-23 05:50:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 06:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 06:04:11]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[dominickn, 2017-06-23 06:50:51]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-23 06:51:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-23 07:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-23 07:05:48]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[benwells, 2017-06-24 00:35:30]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2017-06-24 00:35:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 01:04:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498264530971440, "parent_rev":
"bf104c1b3d2dfae83774369a9c6a890ad57b9d6e", "commit_rev":
"339d7dc9d0e5c64329105314a52413025b18b89c"}

[commit-bot: I haz the power, 2017-06-24 01:04:38]

Description was changed from

==========
Stop the banner pipeline from being triggered if it is already active.

This is a speculative fix for crbug.com/736045. If we tip over the
engagement threshold while the app banner pipeline is active, and we've
already started the banenr checking due to the onload experiment, we
could get into a state where RequestAppBanner is called but we haven't
stopped the previous run.

This CL guards all calls to RequestAppBanner on the banner pipeline not
being active.

BUG=736045
==========

to

==========
Stop the banner pipeline from being triggered if it is already active.

This is a speculative fix for crbug.com/736045. If we tip over the
engagement threshold while the app banner pipeline is active, and we've
already started the banenr checking due to the onload experiment, we
could get into a state where RequestAppBanner is called but we haven't
stopped the previous run.

This CL guards all calls to RequestAppBanner on the banner pipeline not
being active.

BUG=736045

Review-Url: https://codereview.chromium.org/2958473002
Cr-Commit-Position: refs/heads/master@{#482103}
Committed:
https://chromium.googlesource.com/chromium/src/+/339d7dc9d0e5c64329105314a524...
==========

[commit-bot: I haz the power, 2017-06-24 01:04:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/339d7dc9d0e5c64329105314a524...