Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2958463002: Update Google API keys header comment. (Closed)

Created:
3 years, 6 months ago by robertshield
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Google API keys header comment. Mention that env var overrides don't work in Google Chrome builds. BUG=710575 Review-Url: https://codereview.chromium.org/2958463002 Cr-Commit-Position: refs/heads/master@{#481872} Committed: https://chromium.googlesource.com/chromium/src/+/8d06e9e1d811adc8b28cf9b65552e9affe6ce60e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M google_apis/google_api_keys.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
robertshield
3 years, 6 months ago (2017-06-23 04:17:44 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm
3 years, 6 months ago (2017-06-23 11:19:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958463002/1
3 years, 6 months ago (2017-06-23 13:10:29 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 14:09:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d06e9e1d811adc8b28cf9b65552...

Powered by Google App Engine
This is Rietveld 408576698