Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2958433002: [errors] Remove Fix(), move MultiErrorFromErrors(). (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[errors] Remove Fix(), move MultiErrorFromErrors(). Fix is no longer used by anything, and MultiErrorFromErrors is purpose-built for the common/sync/parallel package, so it's a better fit there. R=dnj@chromium.org, vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2958433002 Committed: https://github.com/luci/luci-go/commit/b2857583f8981670a82a1f52a249d93760b96de1

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused type #

Patch Set 3 : keep it secret, keep it safe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -107 lines) Patch
M common/errors/annotate_example_test.go View 3 chunks +10 lines, -5 lines 0 comments Download
M common/errors/multierror.go View 2 chunks +0 lines, -40 lines 0 comments Download
M common/errors/multierror_test.go View 1 3 chunks +0 lines, -61 lines 0 comments Download
A common/sync/parallel/multierror_test.go View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M common/sync/parallel/workPool.go View 1 2 2 chunks +21 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
iannucci
3 years, 6 months ago (2017-06-23 00:23:17 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/2958433002/diff/1/common/sync/parallel/workPool.go File common/sync/parallel/workPool.go (right): https://codereview.chromium.org/2958433002/diff/1/common/sync/parallel/workPool.go#newcode41 common/sync/parallel/workPool.go:41: func MultiErrorFromErrors(ch <-chan error) error { does it ...
3 years, 6 months ago (2017-06-23 00:32:16 UTC) #2
iannucci
done
3 years, 6 months ago (2017-06-23 00:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958433002/40001
3 years, 6 months ago (2017-06-23 00:38:43 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:55:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/b2857583f8981670a82a1f52a249d93760b96de1

Powered by Google App Engine
This is Rietveld 408576698