Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(268)

Issue 2958353002: [Cleanup] Migrate the StatisticsProvider to use the TaskScheduler (Closed)

Created:
1 year, 8 months ago by Ilya Sherman
Modified:
1 year, 8 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, achuith+watch_chromium.org, jshin+watch_chromium.org, asvitkine+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Migrate the StatisticsProvider to use the TaskScheduler BUG=667892 TEST=none Review-Url: https://codereview.chromium.org/2958353002 Cr-Commit-Position: refs/heads/master@{#483772} Committed: https://chromium.googlesource.com/chromium/src/+/904f82feaaf91128033fea4637a994c37b59a084

Patch Set 1 #

Patch Set 2 : A bunch of little fixes #

Patch Set 3 : Rebase #

Patch Set 4 : Add missing #include #

Patch Set 5 : remove obsolete fwd-declarations #

Patch Set 6 : rewrap a line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -72 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chromeos_metrics_provider.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc View 1 2 3 4 3 chunks +7 lines, -39 lines 0 comments Download
M chromeos/system/fake_statistics_provider.h View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M chromeos/system/fake_statistics_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/system/statistics_provider.h View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 34 (29 generated)
Ilya Sherman
Steven, PTAL at everything Chrome OS related. Alexei, PTAL at the metrics files. Thanks!
1 year, 8 months ago (2017-06-30 03:01:53 UTC) #22
Alexei Svitkine (slow)
lgtm
1 year, 8 months ago (2017-06-30 14:45:30 UTC) #23
stevenjb
lgtm
1 year, 8 months ago (2017-06-30 18:18:47 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958353002/100001
1 year, 8 months ago (2017-06-30 18:30:19 UTC) #31
commit-bot: I haz the power
1 year, 8 months ago (2017-06-30 18:36:52 UTC) #34
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/904f82feaaf91128033fea4637a9...

Powered by Google App Engine
This is Rietveld 408576698