Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2958333003: Remove dfalcantara@ from OWNERS (Closed)

Created:
3 years, 5 months ago by gone
Modified:
3 years, 5 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dfalcantara+watch_chromium.org, dominickn+watch_chromium.org, dtrainor+watch_chromium.org, jam, jbroman+cpp_chromium.org, pkotwicz+watch_chromium.org, vmpstr+watch_chromium.org, zpeng+watch_chromium.org, David Trainor- moved to gerrit
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dfalcantara@ from OWNERS BUG=None Review-Url: https://codereview.chromium.org/2958333003 Cr-Commit-Position: refs/heads/master@{#483230} Committed: https://chromium.googlesource.com/chromium/src/+/0d07914a74851ab7f58a96cdc2ec2b563ffbcca8

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove dfalcantara@ from OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -51 lines) Patch
M chrome/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/res/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/banners/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/locale/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tabmodel/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/infobar/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/omaha/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/document/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/translate/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/banners/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/metrics/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/search_geolocation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/webapk/OWNERS View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/webapps/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/banners/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bitmap_fetcher/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/android/content_settings/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/tab_contents/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/android/tab_model/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/manifest/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/android/java/res/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/crypto/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/crypto/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M styleguide/java/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
gone
sky: need you for chrome/browser/sessions/OWNERS mlamouri: need you for content/browser/manifest/OWNERS ted: all the rest
3 years, 5 months ago (2017-06-28 21:47:11 UTC) #2
mlamouri (slow - plz ping)
sad lgtm
3 years, 5 months ago (2017-06-28 22:02:49 UTC) #4
Ted C
:-( lgtm https://codereview.chromium.org/2958333003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS (left): https://codereview.chromium.org/2958333003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS#oldcode1 chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS:1: dfalcantara@chromium.org should we add nyquist here? https://codereview.chromium.org/2958333003/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/OWNERS ...
3 years, 5 months ago (2017-06-28 22:32:41 UTC) #5
gone
https://codereview.chromium.org/2958333003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS (left): https://codereview.chromium.org/2958333003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS#oldcode1 chrome/android/java/src/org/chromium/chrome/browser/omaha/OWNERS:1: dfalcantara@chromium.org On 2017/06/28 22:32:41, Ted C wrote: > should ...
3 years, 5 months ago (2017-06-28 22:47:40 UTC) #6
gone
+nyquist for input on the omaha OWNERS change
3 years, 5 months ago (2017-06-28 22:50:52 UTC) #8
sky
LGTM
3 years, 5 months ago (2017-06-28 23:09:49 UTC) #9
nyquist
chrome/android/java/src/org/chromium/chrome/browser/omaha lgtm until the omaha team takes over. dtrainor: FYI
3 years, 5 months ago (2017-06-28 23:47:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958333003/20001
3 years, 5 months ago (2017-06-28 23:48:43 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 00:49:49 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d07914a74851ab7f58a96cdc2ec...

Powered by Google App Engine
This is Rietveld 408576698