Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2958313002: Disable broken web tests in presubmit. (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Change typescript pin to ~2.3. This should unblock CQ, but should also prevent us from upgrading to 2.4, which has some stricter checks that find bugs in logdog. R=dnj@chromium.org, vadimsh@chromium.org BUG=737631 Review-Url: https://codereview.chromium.org/2958313002 Committed: https://github.com/luci/luci-go/commit/2ae56cd555233728c302e9a67d229fc35aaf007f

Patch Set 1 #

Patch Set 2 : Try changing semver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M web/package.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
iannucci
3 years, 5 months ago (2017-06-28 17:30:15 UTC) #1
Vadim Sh.
rs lgtm to unblock CQ
3 years, 5 months ago (2017-06-28 17:38:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958313002/20001
3 years, 5 months ago (2017-06-28 17:49:58 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 17:54:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/2ae56cd555233728c302e9a67d229fc35aaf007f

Powered by Google App Engine
This is Rietveld 408576698