Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2958283003: [wasm] Naming convention: get_origin() -> origin() (Closed)

Created:
3 years, 5 months ago by Mircea Trofin
Modified:
3 years, 5 months ago
Reviewers:
kschimpf, bradnelson
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Naming convention: get_origin() -> origin() The naming convention in v8 has trivial getters named like the field, no 'get_' prefix, and dropping the '_' suffix of the field. BUG= Review-Url: https://codereview.chromium.org/2958283003 Cr-Commit-Position: refs/heads/master@{#46332} Committed: https://chromium.googlesource.com/v8/v8/+/943f8fb2646952c28ca6b6e158b243b0d4143683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler/wasm-compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/wasm/module-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Mircea Trofin
PTAL
3 years, 5 months ago (2017-06-29 01:59:02 UTC) #5
bradnelson
lgtm
3 years, 5 months ago (2017-06-29 18:28:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958283003/1
3 years, 5 months ago (2017-06-29 18:28:55 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 18:30:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/943f8fb2646952c28ca6b6e158b243b0d41...

Powered by Google App Engine
This is Rietveld 408576698