Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2958253002: [turbofan] Replace uninitialized JSConstruct nodes with SOFT deopt. (Closed)

Created:
3 years, 5 months ago by Benedikt Meurer
Modified:
3 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Replace uninitialized JSConstruct nodes with SOFT deopt. Similar to JSCall, we can also replace uninitialized JSConstruct nodes with SOFT deopts to ensure that we don't generate unnecessary dead code. This for example shows up in the hot parts of the Node event emitter currently where the generic code for handling events with 4 or more parameters might not have been run, but we still generate most of the code because the new Array call in the beginning is not turned into a SOFT deopt immediately. Drive-by-fix: Also refactor the BytecodeGraphBuilder's handling of Construct bytecodes a bit to reduce the amount of code duplication. BUG=v8:4551, v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2958253002 Cr-Commit-Position: refs/heads/master@{#46339} Committed: https://chromium.googlesource.com/v8/v8/+/fd24deb0b2b540a30dc48b06d3cd62b356169003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -71 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 4 chunks +67 lines, -51 lines 0 comments Download
M src/compiler/js-call-reducer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 3 chunks +28 lines, -12 lines 0 comments Download
M src/compiler/js-type-hint-lowering.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/ignition/throw-if-not-hole.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 5 months ago (2017-06-28 11:23:49 UTC) #1
Jarin
lgtm
3 years, 5 months ago (2017-06-30 07:48:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958253002/1
3 years, 5 months ago (2017-06-30 07:49:17 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 08:18:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fd24deb0b2b540a30dc48b06d3cd62b3561...

Powered by Google App Engine
This is Rietveld 408576698