Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2958243002: Allow outdirs when !enable_extensions and !enable_print_preview (Closed)

Created:
3 years, 5 months ago by hugoh_UTC2
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow outdirs when !enable_extensions and !enable_print_preview This lets us generate outdirs for builds where enable_extensions and enable_print_preview are false. This is a configuration that is used by Opera's TV SDK. This can be seen as a fixup to https://codereview.chromium.org/2904443004/ . BUG=725906 TEST=gn gen --args='enable_extensions=false enable_print_preview=false' out/GnTest Review-Url: https://codereview.chromium.org/2958243002 Cr-Commit-Position: refs/heads/master@{#483654} Committed: https://chromium.googlesource.com/chromium/src/+/02b18b7bde2afa136db8c79fab03943f68ccb5fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/test/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
hugoh_UTC2
dpranke@ PTAL
3 years, 5 months ago (2017-06-28 10:26:15 UTC) #2
Dirk Pranke
lgtm
3 years, 5 months ago (2017-06-28 20:35:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958243002/1
3 years, 5 months ago (2017-06-29 07:02:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/479061)
3 years, 5 months ago (2017-06-29 07:47:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958243002/1
3 years, 5 months ago (2017-06-30 06:09:46 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 08:06:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02b18b7bde2afa136db8c79fab03...

Powered by Google App Engine
This is Rietveld 408576698