[CSS Typed OM] Implement CSSUnit::to for fixed length types

[CSS Typed OM] Implement CSSUnitValue::to for fixed length types

This applies when converting CSSUnitValues to other CSSUnitValues.

https://drafts.css-houdini.org/css-typed-om/#dom-cssnumericvalue-to

BUG=545318
Review-Url: https://codereview.chromium.org/2958233002
Cr-Commit-Position: refs/heads/master@{#485198}
Committed: https://chromium.googlesource.com/chromium/src/+/ca98682a5e2fcea39dd2fbffed9541e927fd5a40

[meade_UTC10, 2017-06-28 08:33:43]

meade@chromium.org changed reviewers:
+ bugsnash@chromium.org

[meade_UTC10, 2017-06-28 08:33:44]

Hi bugs, PTAL

[meade_UTC10, 2017-06-28 08:35:12]

Description was changed from

==========
[CSS Typed OM] Implement CSSUnit::to for fixed length types

BUG=545318
==========

to

==========
[CSS Typed OM] Implement CSSUnitValue::to for fixed length types

This applies when converting CSSUnitValues to other CSSUnitValues.

https://drafts.css-houdini.org/css-typed-om/#dom-cssnumericvalue-to

BUG=545318
==========

[Bugs Nash, 2017-06-28 23:50:27]

lgtm with nits

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp (right):

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:88: // TODO(meade):
Implement other types.
how many more types need to be implemented? is it feasible to include in this
todo the remaining types?

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:90: // Only some kinds
of lengths can be converted
perhaps 'relative types of lengths cannot be converted' is clearer?

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:128: return value_ *
(kCssPixelsPerCentimeter / kCssPixelsPerInch);
why do the pixels consts need to be used when converting between centimeters,
inches, points, or picas? they are all independent of pixels and could be
literal equations like the conversion from centimeters to millimeters right? if
you prefer using these named consts instead of literal equations i would suggest
being consistent and doing the same with the cm to mm conversions

[meade_UTC10, 2017-06-29 06:44:09]

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp (right):

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:88: // TODO(meade):
Implement other types.
On 2017/06/28 23:50:27, Bugs Nash wrote:
> how many more types need to be implemented? is it feasible to include in this
> todo the remaining types?

Done.

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:90: // Only some kinds
of lengths can be converted
On 2017/06/28 23:50:27, Bugs Nash wrote:
> perhaps 'relative types of lengths cannot be converted' is clearer?

Done.

https://codereview.chromium.org/2958233002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp:128: return value_ *
(kCssPixelsPerCentimeter / kCssPixelsPerInch);
On 2017/06/28 23:50:27, Bugs Nash wrote:
> why do the pixels consts need to be used when converting between centimeters,
> inches, points, or picas? they are all independent of pixels and could be
> literal equations like the conversion from centimeters to millimeters right?
if
> you prefer using these named consts instead of literal equations i would
suggest
> being consistent and doing the same with the cm to mm conversions

It was a convenient way to do conversions without defining a large number of new
constants, and I think the less-well-known conversions (i.e. not =10) constants
need to be named. I defined a small number of new constants and made the
calculations with respect to those.

[meade_UTC10, 2017-07-03 05:24:51]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-07-03 05:24:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2958233002/#ps60001
(title: "remove spurious build file change")

[commit-bot: I haz the power, 2017-07-03 05:25:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 05:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 05:33:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[meade_UTC10, 2017-07-05 07:03:40]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-07-05 07:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2958233002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-07-05 07:04:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 07:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-05 07:59:31]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[meade_UTC10, 2017-07-07 06:54:03]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-07-07 06:54:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2958233002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-07-07 06:54:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 08:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 08:02:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[meade_UTC10, 2017-07-10 02:47:43]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2017-07-10 02:47:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2958233002/#ps120001
(title: "Use new constants")

[commit-bot: I haz the power, 2017-07-10 02:47:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 07:14:57]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1499654863655620,
"parent_rev": "73c48a971009b7a0252227924844ae0cab883231", "commit_rev":
"ca98682a5e2fcea39dd2fbffed9541e927fd5a40"}

[commit-bot: I haz the power, 2017-07-10 07:15:16]

Description was changed from

==========
[CSS Typed OM] Implement CSSUnitValue::to for fixed length types

This applies when converting CSSUnitValues to other CSSUnitValues.

https://drafts.css-houdini.org/css-typed-om/#dom-cssnumericvalue-to

BUG=545318
==========

to

==========
[CSS Typed OM] Implement CSSUnitValue::to for fixed length types

This applies when converting CSSUnitValues to other CSSUnitValues.

https://drafts.css-houdini.org/css-typed-om/#dom-cssnumericvalue-to

BUG=545318

Review-Url: https://codereview.chromium.org/2958233002
Cr-Commit-Position: refs/heads/master@{#485198}
Committed:
https://chromium.googlesource.com/chromium/src/+/ca98682a5e2fcea39dd2fbffed95...
==========

[commit-bot: I haz the power, 2017-07-10 07:15:17]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ca98682a5e2fcea39dd2fbffed95...