Ensure races between pending and new SPDY streams don't violate session concurrency.

Ensure races between pending and new SPDY streams don't violate session concurrency.

Unstalled pending streams now check that a slot is still available, after posting.
A unit-test is added to detect regressions.

BUG=373858
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271534

[Ryan Hamilton, 2014-05-19 23:00:07]

lgtm

https://codereview.chromium.org/295823002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/295823002/diff/1/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:2868: if (rv == OK) {
How 'bout early return here:

if (rv == OK) {
  DCHECK(stream);
  pending_request->OnRequestCompleteSuccess(stream);
  return;
}

DCHECK(!stream);
if (rv != ERR_IO_PENDING)
  pending_request->OnRequestCompleteFailure(rv);

[Johnny, 2014-05-19 23:37:32]

https://codereview.chromium.org/295823002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/295823002/diff/1/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:2868: if (rv == OK) {
On 2014/05/19 23:00:07, Ryan Hamilton wrote:
> How 'bout early return here:
> 
> if (rv == OK) {
>   DCHECK(stream);
>   pending_request->OnRequestCompleteSuccess(stream);
>   return;
> }
> 
> DCHECK(!stream);
> if (rv != ERR_IO_PENDING)
>   pending_request->OnRequestCompleteFailure(rv);
> 

Done.

[Johnny, 2014-05-19 23:38:53]

The CQ bit was checked by jgraettinger@chromium.org

[commit-bot: I haz the power, 2014-05-19 23:40:04]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/295823002/20001

[commit-bot: I haz the power, 2014-05-20 02:02:08]

Change committed as 271534