net/spdy/spdy_session.h - Issue 295823002: Ensure races between pending and new SPDY streams don't violate session concurrency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.h

Issue 295823002: Ensure races between pending and new SPDY streams don't violate session concurrency. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switch to early return. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_session.h

diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h

index 898d85c3f62795ab3b57effc7c90c3d5848713d2..80578b849f3aba87ca2cfcff842d720345a1b3fa 100644

--- a/net/spdy/spdy_session.h

+++ b/net/spdy/spdy_session.h

@@ -494,6 +494,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,

FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, SessionFlowControlNoSendLeaks);

FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, SessionFlowControlEndToEnd);

FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, StreamIdSpaceExhausted);

+ FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, UnstallRacesWithStreamCreation);

typedef std::deque<base::WeakPtr<SpdyStreamRequest> >

PendingStreamRequestQueue;

« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »