Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2958153002: MD-Settings: Don't use title as a property because it's overloaded. (Closed)

Created:
3 years, 5 months ago by hcarmona
Modified:
3 years, 5 months ago
Reviewers:
tsergeant, Devlin, michaelpg
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-Settings: Don't use title as a property because it's overloaded. R=michaelpg@chromium.org BUG=737077 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2958153002 Cr-Commit-Position: refs/heads/master@{#482853} Committed: https://chromium.googlesource.com/chromium/src/+/35483c504bb197da94e4f4093426c7d26023e24f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/md_extensions/manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/cr_drawer/cr_drawer.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
hcarmona
PTAL
3 years, 5 months ago (2017-06-27 21:55:04 UTC) #3
michaelpg
thanks html.... lgtm
3 years, 5 months ago (2017-06-27 23:48:03 UTC) #7
hcarmona
+devlin for chrome/browser/resources/md_extensions +tsergeant for chrome/browser/resources/md_history
3 years, 5 months ago (2017-06-28 00:37:47 UTC) #9
tsergeant
lgtm
3 years, 5 months ago (2017-06-28 00:44:59 UTC) #10
Devlin
extensions lgtm
3 years, 5 months ago (2017-06-28 01:03:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958153002/1
3 years, 5 months ago (2017-06-28 01:25:38 UTC) #13
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 02:15:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35483c504bb197da94e4f4093426...

Powered by Google App Engine
This is Rietveld 408576698