gpu/command_buffer/service/shader_translator.h - Issue 295803002: Moves responsibility for shader resource string generation to ANGLE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/shader_translator.h

Issue 295803002: Moves responsibility for shader resource string generation to ANGLE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK for string length Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/shader_translator.h

diff --git a/gpu/command_buffer/service/shader_translator.h b/gpu/command_buffer/service/shader_translator.h

index b9bacf155e6a2db00edcc48a27a2a6465ac09640..d993967da9b1533e3f3c8af0335a958973dd8640 100644

--- a/gpu/command_buffer/service/shader_translator.h

+++ b/gpu/command_buffer/service/shader_translator.h

@@ -89,8 +89,8 @@ class ShaderTranslatorInterface {

virtual const NameMap& name_map() const = 0;

// Return a string that is unique for a specfic set of options that would

- // possibly effect compilation.

- virtual std::string GetStringForOptionsThatWouldEffectCompilation() const = 0;

+ // possibly affect compilation.

+ virtual std::string GetStringForOptionsThatWouldAffectCompilation() const = 0;

protected:

virtual ~ShaderTranslatorInterface() {}

@@ -135,7 +135,7 @@ class GPU_EXPORT ShaderTranslator

virtual const VariableMap& varying_map() const OVERRIDE;

virtual const NameMap& name_map() const OVERRIDE;

- virtual std::string GetStringForOptionsThatWouldEffectCompilation() const

+ virtual std::string GetStringForOptionsThatWouldAffectCompilation() const

OVERRIDE;

void AddDestructionObserver(DestructionObserver* observer);

« no previous file with comments | « gpu/command_buffer/service/program_cache.cc ('k') | gpu/command_buffer/service/shader_translator.cc » ('j') | no next file with comments »