gpu/command_buffer/service/program_cache.cc - Issue 295803002: Moves responsibility for shader resource string generation to ANGLE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/program_cache.cc

Issue 295803002: Moves responsibility for shader resource string generation to ANGLE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add DCHECK for string length Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/command_buffer/service/program_cache.cc

diff --git a/gpu/command_buffer/service/program_cache.cc b/gpu/command_buffer/service/program_cache.cc

index 6599d4ad3d99fbbe5025a3166e85946ca704ac1e..ad395c7f4766d16a0ec9c93e0b1cb2c1ca1a6284 100644

--- a/gpu/command_buffer/service/program_cache.cc

+++ b/gpu/command_buffer/service/program_cache.cc

@@ -74,7 +74,7 @@ void ProgramCache::ComputeShaderHash(

const ShaderTranslatorInterface* translator,

char* result) const {

std::string s((

- translator ? translator->GetStringForOptionsThatWouldEffectCompilation() :

+ translator ? translator->GetStringForOptionsThatWouldAffectCompilation() :

std::string()) + str);

base::SHA1HashBytes(reinterpret_cast<const unsigned char*>(s.c_str()),

s.length(), reinterpret_cast<unsigned char*>(result));

« no previous file with comments | « gpu/command_buffer/service/mocks.h ('k') | gpu/command_buffer/service/shader_translator.h » ('j') | no next file with comments »