Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2957943002: [CRD iOS] Add the host setup instruction page (Closed)

Created:
3 years, 5 months ago by Yuwei
Modified:
3 years, 5 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Add the host setup instruction page This CL adds the host setup view to inform the user to setup the host when there is no host in the list. Please see this screenshot: https://drive.google.com/file/d/0BytzIZKeM8nBdzBoWlN3R3hGSWM/view?usp=sharing This CL also fixes some color scheme issue. Previously the host collection list is using opacity to lighten the color. BUG=736932 Review-Url: https://codereview.chromium.org/2957943002 Cr-Commit-Position: refs/heads/master@{#482832} Committed: https://chromium.googlesource.com/chromium/src/+/e3872416cbc8896a54bb571539202bf0e24fcac2

Patch Set 1 #

Patch Set 2 : Add comment #

Total comments: 11

Patch Set 3 : Resolve Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -66 lines) Patch
M remoting/ios/app/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/ios/app/app_delegate.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/ios/app/app_delegate.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/ios/app/host_collection_view_cell.mm View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/ios/app/host_collection_view_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M remoting/ios/app/host_collection_view_controller.mm View 3 chunks +2 lines, -24 lines 0 comments Download
A remoting/ios/app/host_setup_footer_view.h View 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_footer_view.mm View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_header_view.h View 1 chunk +14 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_header_view.mm View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_view_cell.h View 1 chunk +17 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_view_cell.mm View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_view_controller.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
A remoting/ios/app/host_setup_view_controller.mm View 1 2 1 chunk +123 lines, -0 lines 0 comments Download
M remoting/ios/app/remoting_theme.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/ios/app/remoting_theme.mm View 1 2 2 chunks +23 lines, -2 lines 0 comments Download
M remoting/ios/app/remoting_view_controller.mm View 8 chunks +54 lines, -19 lines 0 comments Download
M remoting/ios/facade/host_list_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/ios/facade/remoting_service.h View 2 chunks +14 lines, -1 line 0 comments Download
M remoting/ios/facade/remoting_service.mm View 5 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Yuwei
PTAL thanks! https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_collection_view_controller.mm File remoting/ios/app/host_collection_view_controller.mm (left): https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_collection_view_controller.mm#oldcode144 remoting/ios/app/host_collection_view_controller.mm:144: MDCShadowLayer* shadowLayer = [MDCShadowLayer layer]; This logic ...
3 years, 5 months ago (2017-06-26 23:31:13 UTC) #2
nicholss
lgtm, some minor suggestions on cleanup https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_setup_footer_view.mm File remoting/ios/app/host_setup_footer_view.mm (right): https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_setup_footer_view.mm#newcode33 remoting/ios/app/host_setup_footer_view.mm:33: [raisedButton setTitleColor:UIColor.whiteColor forState:UIControlStateNormal]; ...
3 years, 5 months ago (2017-06-27 16:36:02 UTC) #3
Yuwei
Thanks! https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_setup_footer_view.mm File remoting/ios/app/host_setup_footer_view.mm (right): https://codereview.chromium.org/2957943002/diff/20001/remoting/ios/app/host_setup_footer_view.mm#newcode33 remoting/ios/app/host_setup_footer_view.mm:33: [raisedButton setTitleColor:UIColor.whiteColor forState:UIControlStateNormal]; On 2017/06/27 16:36:01, nicholss wrote: ...
3 years, 5 months ago (2017-06-27 20:46:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957943002/40001
3 years, 5 months ago (2017-06-27 20:47:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/477414)
3 years, 5 months ago (2017-06-27 22:26:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957943002/40001
3 years, 5 months ago (2017-06-27 22:30:39 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:03:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e3872416cbc8896a54bb57153920...

Powered by Google App Engine
This is Rietveld 408576698