third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp - Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

index 46e23a955f615725a7310d28ccdff9c6ab0d74cf..b1eb43c45f2d3d59d22359c46454ac4b8a293593 100644

--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

@@ -901,7 +901,7 @@ void TypingCommand::ForwardDeleteKeyPressed(TextGranularity granularity,

EnclosingNodeOfType(visible_end.DeepEquivalent(), &IsTableCell);

if (enclosing_table_cell &&

visible_end.DeepEquivalent() ==

- VisiblePosition::LastPositionInNode(enclosing_table_cell)

+ VisiblePosition::LastPositionInNode(*enclosing_table_cell)

.DeepEquivalent())

return;

if (visible_end.DeepEquivalent() ==

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | no next file » | no next file with comments »