third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index a28357e8d29937dd7e01b2d601628aee23a6b678..aa321401e78016af2a66fb572f345344f8b33b79 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -633,9 +633,9 @@ void ReplaceSelectionCommand::RemoveRedundantStylesAndKeepStyleSpanInline(

VisiblePosition::FirstPositionInNode(*element->parentNode())

.DeepEquivalent() ==

VisiblePosition::FirstPositionInNode(*element).DeepEquivalent() &&

- VisiblePosition::LastPositionInNode(element->parentNode())

+ VisiblePosition::LastPositionInNode(*element->parentNode())

.DeepEquivalent() ==

- VisiblePosition::LastPositionInNode(element).DeepEquivalent()) {

+ VisiblePosition::LastPositionInNode(*element).DeepEquivalent()) {

inserted_nodes.WillRemoveNodePreservingChildren(*element);

RemoveNodePreservingChildren(element, editing_state);

if (editing_state->IsAborted())

@@ -735,7 +735,7 @@ void ReplaceSelectionCommand::MoveElementOutOfAncestor(

VisiblePosition position_at_end_of_node =

CreateVisiblePosition(LastPositionInOrAfterNode(element));

VisiblePosition last_position_in_paragraph =

- VisiblePosition::LastPositionInNode(ancestor);

+ VisiblePosition::LastPositionInNode(*ancestor);

if (position_at_end_of_node.DeepEquivalent() ==

last_position_in_paragraph.DeepEquivalent()) {

RemoveNode(element, editing_state);