Issue 2957773002: Revert "VM: Fix ARM64 assembler tests that assumed there was a stack red zone"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2957773002: Revert "VM: Fix ARM64 assembler tests that assumed there was a stack red zone" (Closed)

Created:
3 years, 5 months ago by erikcorry

Modified:
3 years, 5 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "VM: Fix ARM64 assembler tests that assumed there was a stack red zone" R=whesse@google.com BUG= This reverts commit aab30779b50e57db14f6e6ecb196a68f9e886bbb due to crashes on real hardware. Original CL: https://codereview.chromium.org/2953803002 Committed: https://github.com/dart-lang/sdk/commit/c460e2fc19dbc49340139b4f4b64736b682f267e

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -84 lines)			Patch
	M	runtime/vm/assembler_arm64_test.cc	View		52 chunks	+66 lines, -84 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 5 months ago (2017-06-26 14:20:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c460e2fc19dbc49340139b4f4b64736b682f267e (presubmit successful).