Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2953803002: VM: Fix ARM64 assembler tests that assumed there was a stack red zone (Closed)

Created:
3 years, 6 months ago by erikcorry
Modified:
3 years, 5 months ago
Reviewers:
Bill Hesse, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix ARM64 assembler tests that assumed there was a stack red zone R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/aab30779b50e57db14f6e6ecb196a68f9e886bbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -66 lines) Patch
M runtime/vm/assembler_arm64_test.cc View 52 chunks +84 lines, -66 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
erikcorry
3 years, 6 months ago (2017-06-22 13:18:09 UTC) #1
kustermann
LGTM
3 years, 5 months ago (2017-06-26 11:04:55 UTC) #2
erikcorry
Committed patchset #1 (id:1) manually as aab30779b50e57db14f6e6ecb196a68f9e886bbb (presubmit successful).
3 years, 5 months ago (2017-06-26 11:23:58 UTC) #4
Bill Hesse
3 years, 5 months ago (2017-06-26 13:46:36 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698