Provide feedback for multi-line selections

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Processes events related to editing text and emits the
  * appropriate spoken and braille feedback.
  */
 
 goog.provide('editing.TextEditHandler');
@@ skipping 295 matching lines @@
       return;
     }
 
     if (cur.text == '') {
       // This line has no text content. Describe the DOM selection.
       new Output()
           .withRichSpeechAndBraille(
               new Range(cur.start_, cur.end_),
               new Range(prev.start_, prev.end_), Output.EventType.NAVIGATE)
           .go();
+    } else if (!cur.hasCollapsedSelection()) {
+      // This is a selection.
+      cvox.ChromeVox.tts.speak(cur.selectedText, cvox.QueueMode.CATEGORY_FLUSH);

[dmazzoni, 2017/06/23 19:50:49]

Do you want to do this if there's a lot of selected text?

[David Tseng, 2017/06/23 20:06:09]

I think this is ok since |cur| will be at most a line's worth of text. We can
revisit once others try it out.

+      cvox.ChromeVox.tts.speak(Msgs.getMsg('selected'), cvox.QueueMode.QUEUE);
+      this.brailleCurrentRichLine_();
     } else {
       // Describe the current line. This accounts for previous/current
       // selections and picking the line edge boundary that changed (as computed
       // above). This is also the code path for describing paste.
       cvox.ChromeVox.tts.speak(cur.text, cvox.QueueMode.CATEGORY_FLUSH);
       this.brailleCurrentRichLine_();
     }
 
     // The state in EditableTextBase needs to get updated with the new line
     // contents, so that subsequent intra-line changes get the right state
@@ skipping 408 matching lines @@
   },
 
   /**
    * The text content of this line.
    * @return {string} The text of this line.
    */
   get text() {
     return this.value_.toString();
   },
 
+  /** @return {string} */
+  get selectedText() {
+    return this.value_.toString().substring(this.startOffset, this.endOffset);
+  },
+
+  /** @return {boolean} */
+  hasCollapsedSelection: function() {
+    return this.start_.equals(this.end_);
+  },
+
   /**
    * Returns true if |otherLine| surrounds the same line as |this|. Note that
    * the contents of the line might be different.
    * @param {editing.EditableLine} otherLine
    * @return {boolean}
    */
   isSameLine: function(otherLine) {
     // Equality is intentionally loose here as any of the state nodes can be
     // invalidated at any time. We rely upon the start/anchor of the line
     // staying the same.
@@ skipping 12 matching lines @@
    * @return {boolean}
    */
   isSameLineAndSelection: function(otherLine) {
     return this.isSameLine(otherLine) &&
         this.startOffset == otherLine.startOffset &&
         this.endOffset == otherLine.endOffset;
   }
 };
 
 });