Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2957583003: Fix computation of default values for named parameters. (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix computation of default values for named parameters. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1298af3bd3014c0c219823a707d63f39bd1a2b5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -36 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-23 12:25:51 UTC) #2
Siggi Cherem (dart-lang)
lgtm, neat!
3 years, 6 months ago (2017-06-23 19:52:25 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-06-26 09:37:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1298af3bd3014c0c219823a707d63f39bd1a2b5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698