slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py - Issue 295753002: upload SKP renderings that did not match expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py

Issue 295753002: upload SKP renderings that did not match expectations (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py

diff --git a/slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py b/slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py

index ff89cd498491d2c6d09c824107d406dff54d0a1e..f0edaa9dada0aa18ddcfa66f22133b9443aea4f3 100644

--- a/slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py

+++ b/slave/skia_slave_scripts/flavor_utils/android_build_step_utils.py

@@ -119,7 +119,6 @@ class AndroidBuildStepUtils(DefaultBuildStepUtils):

def RunGYP(self):

print 'android_ninja handles gyp'

- pass

def Compile(self, target):

""" Compile the Skia executables. """

@@ -164,14 +163,18 @@ class AndroidBuildStepUtils(DefaultBuildStepUtils):

android_utils.PATH_TO_ADB, self._serial),

echo=True, shell=True).rstrip().split('\n')[-1]

prefix = posixpath.join(device_scratch_dir, 'skiabot', 'skia_')

- return DeviceDirs(perf_data_dir=prefix + 'perf',

- gm_actual_dir=prefix + 'gm_actual',

- gm_expected_dir=prefix + 'gm_expected',

- resource_dir=prefix + 'resources',

- skimage_in_dir=prefix + 'skimage_in',

- skimage_expected_dir=prefix + 'skimage_expected',

- skimage_out_dir=prefix + 'skimage_out',

- skp_dir=prefix + 'skp',

- skp_perf_dir=prefix + 'skp_perf',

- skp_out_dir=prefix + 'skp_out',

- tmp_dir=prefix + 'tmp_dir')

+ return DeviceDirs(

+ perf_data_dir=prefix + 'perf',

+ gm_actual_dir=prefix + 'gm_actual',

+ gm_expected_dir=prefix + 'gm_expected',

+ resource_dir=prefix + 'resources',

+ skimage_in_dir=prefix + 'skimage_in',

+ skimage_expected_dir=prefix + 'skimage_expected',

+ skimage_out_dir=prefix + 'skimage_out',

+ skp_dir=prefix + 'skp',

+ skp_perf_dir=prefix + 'skp_perf',

+ playback_actual_images_dir=prefix + 'playback_actual_images',

+ playback_actual_summaries_dir=prefix + 'playback_actual_summaries',

+ playback_expected_summaries_dir=(

+ prefix + 'playback_expected_summaries'),

+ tmp_dir=prefix + 'tmp_dir')

« no previous file with comments | « slave/skia_slave_scripts/build_step.py ('k') | slave/skia_slave_scripts/flavor_utils/default_build_step_utils.py » ('j') | no next file with comments »