| Index: slave/skia_slave_scripts/build_step.py
|
| diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py
|
| index 37f88d0ae17ec991fc76b9b2b4e7bdec4a3a8e3c..8c31b799b0ffd44a2b470638d81329498e725348 100644
|
| --- a/slave/skia_slave_scripts/build_step.py
|
| +++ b/slave/skia_slave_scripts/build_step.py
|
| @@ -191,6 +191,12 @@ class BuildStep(multiprocessing.Process):
|
| self._default_make_flags = []
|
| self._default_ninja_flags = []
|
|
|
| + # TODO(epoger): Throughout the buildbot code, we use various terms to refer
|
| + # to the same thing: "skps", "pictures", "replay", "playback".
|
| + # We should pick one of those terms, and rename things so that we are
|
| + # consistent.
|
| + # See https://codereview.chromium.org/295753002/ for additional discussion.
|
| +
|
| # Adding the playback directory transfer objects.
|
| self._local_playback_dirs = LocalSkpPlaybackDirs(
|
| self._builder_name,
|
| @@ -202,7 +208,12 @@ class BuildStep(multiprocessing.Process):
|
| else args['perf_output_basedir'])
|
|
|
| self.skp_dir = self._local_playback_dirs.PlaybackSkpDir()
|
| - self.skp_out_dir = self._local_playback_dirs.PlaybackImageResultsDir()
|
| + self.playback_actual_images_dir = (
|
| + self._local_playback_dirs.PlaybackActualImagesDir())
|
| + self.playback_actual_summaries_dir = (
|
| + self._local_playback_dirs.PlaybackActualSummariesDir())
|
| + self.playback_expected_summaries_dir = (
|
| + self._local_playback_dirs.PlaybackExpectedSummariesDir())
|
|
|
| # Figure out where we are going to store performance related data.
|
| if args['perf_output_basedir'] != 'None':
|
|
|