Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: slave/skia_slave_scripts/run_gm.py

Issue 295753002: upload SKP renderings that did not match expectations (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/run_gm.py
diff --git a/slave/skia_slave_scripts/run_gm.py b/slave/skia_slave_scripts/run_gm.py
index 97efda9bbe686b2dfc68b64c7499b865e472df84..d2ad69688e5919eb42603bedf75aeb29e0c01f41 100644
--- a/slave/skia_slave_scripts/run_gm.py
+++ b/slave/skia_slave_scripts/run_gm.py
@@ -20,6 +20,8 @@ class RunGM(BuildStep):
timeout=timeout, no_output_timeout=no_output_timeout, **kwargs)
def _Run(self):
+ # TODO(epoger): I think some of these os.path.join() calls need to be
epoger 2014/05/19 19:35:40 Am I right about this? If so, I can make the chan
borenet 2014/05/19 21:04:38 Yeah, I think that's true. I think we get lucky b
epoger 2014/05/19 22:07:24 Done.
+ # self._flavor_utils.DevicePathJoin() instead. Seems to work anyway.
output_dir = os.path.join(self._device_dirs.GMActualDir(),
self._builder_name)
cmd = ['--verbose',

Powered by Google App Engine
This is Rietveld 408576698