upload SKP renderings that did not match expectations

slave/skia_slave_scripts/run_gm.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Run the Skia GM executable. """
 
 from build_step import BuildStep
 import build_step
 import os
 import sys
 
 
 JSON_SUMMARY_FILENAME = 'actual-results.json'
 
 
 class RunGM(BuildStep):
   def __init__(self, timeout=9600, no_output_timeout=9600, **kwargs):
     super(RunGM, self).__init__(
       timeout=timeout, no_output_timeout=no_output_timeout, **kwargs)
 
   def _Run(self):
+    # TODO(epoger): I think some of these os.path.join() calls need to be

[epoger, 2014/05/19 19:35:40]

Am I right about this?  If so, I can make the change now if you want...

[borenet, 2014/05/19 21:04:38]

Yeah, I think that's true.  I think we get lucky because we the only time they
*would* differ would be if we attached Android or ChromeOS devices to Windows
machines, which we don't do.

[epoger, 2014/05/19 22:07:24]

Done.

+    # self._flavor_utils.DevicePathJoin() instead.  Seems to work anyway.
     output_dir = os.path.join(self._device_dirs.GMActualDir(),
                               self._builder_name)
     cmd = ['--verbose',
            '--writeChecksumBasedFilenames',
            # Don't bother writing out image files that match our expectations--
            # we know that previous runs have already uploaded those!
            '--mismatchPath', output_dir,
            '--missingExpectationsPath', output_dir,
            '--writeJsonSummaryPath', os.path.join(output_dir,
                                                   JSON_SUMMARY_FILENAME),
@@ skipping 64 matching lines @@
                   '~scaled_tilemodes',
                   '~convexpaths',
                   '~clipped-bitmap',
                   '~xfermodes3'])
 
     self._flavor_utils.RunFlavoredCmd('gm', cmd)
 
 
 if '__main__' == __name__:
   sys.exit(BuildStep.RunBuildStep(RunGM))