upload SKP renderings that did not match expectations

slave/skia_slave_scripts/build_step.py

Index: slave/skia_slave_scripts/build_step.py
diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py
index 5339a8520542b8601527c2f386bdc5ec5b095834..18a3ac354be4db1262aa28b2f357f2a01284d4b2 100644
--- a/slave/skia_slave_scripts/build_step.py
+++ b/slave/skia_slave_scripts/build_step.py
@@ -202,7 +202,12 @@ class BuildStep(multiprocessing.Process):
             else args['perf_output_basedir'])
 
     self.skp_dir = self._local_playback_dirs.PlaybackSkpDir()
-    self.skp_out_dir = self._local_playback_dirs.PlaybackImageResultsDir()
+    self.playback_actual_images_dir = (
+        self._local_playback_dirs.PlaybackActualImagesDir())

[borenet, 2014/05/19 21:04:38]

So I never understood this - what's the deal with "playback"?  Why not name
these as "skp"-something, since that's what they are?

[epoger, 2014/05/19 22:07:24]

It was bugging me too as I wrote the CL, although by the time I'd been "soaking
in it" for a couple days I got over it.

Looks like that has been the case since these late-2012 CLs:
https://codereview.appspot.com/6750057/ ('Script to archive or replay webpages,
generate skp files and store both in Google Storage')
https://codereview.appspot.com/6817062 ('Building on the SkPicture replay
framework')

At any rate, how about I do the following AFTER this CL is committed?  (I can
add them as TODOs now)
1. Rename the build_step fields from self.playback_* to self.skp_*
2. Rename playback_dirs.py as skp_dirs.py, and change names within to follow

It gets a little tricky, because it affects not only render_skps.py but also
bench_pictures.py .  (Maybe we should pick one of "skps", "pictures", or
"replay" and stick with it?)

[epoger, 2014/05/20 19:02:48]

Added a TODO above.

+    self.playback_actual_summaries_dir = (
+        self._local_playback_dirs.PlaybackActualSummariesDir())
+    self.playback_expected_summaries_dir = (
+        self._local_playback_dirs.PlaybackExpectedSummariesDir())
 
     # Figure out where we are going to store performance related data.
     if args['perf_output_basedir'] != 'None':