upload SKP renderings that did not match expectations

slave/skia_slave_scripts/build_step.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Base class for all slave-side build steps. """
 
 import config
 # pylint: disable=W0611
 import flavor_utils
 import imp
@@ skipping 184 matching lines @@
     self._local_playback_dirs = LocalSkpPlaybackDirs(
         self._builder_name,
         None if args['perf_output_basedir'] == 'None'
             else args['perf_output_basedir'])
     self._storage_playback_dirs = StorageSkpPlaybackDirs(
         self._builder_name,
         None if args['perf_output_basedir'] == 'None'
             else args['perf_output_basedir'])
 
     self.skp_dir = self._local_playback_dirs.PlaybackSkpDir()
-    self.skp_out_dir = self._local_playback_dirs.PlaybackImageResultsDir()
+    self.playback_actual_images_dir = (
+        self._local_playback_dirs.PlaybackActualImagesDir())

[borenet, 2014/05/19 21:04:38]

So I never understood this - what's the deal with "playback"?  Why not name
these as "skp"-something, since that's what they are?

[epoger, 2014/05/19 22:07:24]

It was bugging me too as I wrote the CL, although by the time I'd been "soaking
in it" for a couple days I got over it.

Looks like that has been the case since these late-2012 CLs:
https://codereview.appspot.com/6750057/ ('Script to archive or replay webpages,
generate skp files and store both in Google Storage')
https://codereview.appspot.com/6817062 ('Building on the SkPicture replay
framework')

At any rate, how about I do the following AFTER this CL is committed?  (I can
add them as TODOs now)
1. Rename the build_step fields from self.playback_* to self.skp_*
2. Rename playback_dirs.py as skp_dirs.py, and change names within to follow

It gets a little tricky, because it affects not only render_skps.py but also
bench_pictures.py .  (Maybe we should pick one of "skps", "pictures", or
"replay" and stick with it?)

[epoger, 2014/05/20 19:02:48]

Added a TODO above.

+    self.playback_actual_summaries_dir = (
+        self._local_playback_dirs.PlaybackActualSummariesDir())
+    self.playback_expected_summaries_dir = (
+        self._local_playback_dirs.PlaybackExpectedSummariesDir())
 
     # Figure out where we are going to store performance related data.
     if args['perf_output_basedir'] != 'None':
       self._perf_data_dir = os.path.join(args['perf_output_basedir'],
                                          self._builder_name, 'data')
       self._perf_graphs_dir = os.path.join(args['perf_output_basedir'],
                                            self._builder_name, 'graphs')
       self._perf_range_input_dir = os.path.join(
           args['perf_output_basedir'], self._builder_name, 'expectations')
       self._perf_autogen_upload_dir = os.path.join(
@@ skipping 164 matching lines @@
         else:
           raise BuildStepFailure('Build step failed.')
       except Exception:
         print traceback.format_exc()
         if attempt + 1 >= step.attempts:
           raise
       # pylint: disable=W0212
       step._WaitFunc(attempt)
       attempt += 1
       print '**** %s, attempt %d ****' % (StepType.__name__, attempt + 1)