Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Issue 2957453002: Set up TransportSecurityState subcomponents last in ProfileIOData. (Closed)

Created:
3 years, 6 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set up TransportSecurityState subcomponents last in ProfileIOData. They're still set up before the first network request can be made. This allows the main URLRequestContext to be set up using URLRequestContextBuilder without having to inject more objects into the builder. It may make sense to move some of the logic there at some point, but that's an issue for another day. BUG=715695 Review-Url: https://codereview.chromium.org/2957453002 Cr-Commit-Position: refs/heads/master@{#483110} Committed: https://chromium.googlesource.com/chromium/src/+/96d015158540ab690ed826b542e649676966d362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +41 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
mmenke
[estark]: I'm planning to switch creation of URLRequestContext over to URLRequestContextBuilder (Which basically does all ...
3 years, 6 months ago (2017-06-23 00:14:07 UTC) #6
estark
lgtm
3 years, 5 months ago (2017-06-23 16:54:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957453002/1
3 years, 5 months ago (2017-06-28 18:14:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/459718)
3 years, 5 months ago (2017-06-28 19:14:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957453002/1
3 years, 5 months ago (2017-06-28 19:23:12 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:09:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96d015158540ab690ed826b542e6...

Powered by Google App Engine
This is Rietveld 408576698