Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1392)

Issue 2957443002: Dont show search suggestions until search engine promo dialog checks (Closed)

Created:
3 years, 6 months ago by Yusuf
Modified:
3 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Dont show search suggestions until search engine promo dialog checks We should avoid showing search suggest until we have gone through the necessary checks for search engine promo and either has shown it or know that we wont be showing it this session. BUG=729132 Review-Url: https://codereview.chromium.org/2957443002 Cr-Commit-Position: refs/heads/master@{#481728} Committed: https://chromium.googlesource.com/chromium/src/+/091aa4641fcd7ecb421b8241720b53f07b609ee0

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java View 1 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Yusuf
3 years, 6 months ago (2017-06-22 21:50:00 UTC) #2
Ted C
lgtm
3 years, 6 months ago (2017-06-22 22:35:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957443002/1
3 years, 6 months ago (2017-06-22 22:35:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/206011) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 6 months ago (2017-06-22 22:39:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2957443002/20001
3 years, 6 months ago (2017-06-22 22:46:56 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 23:55:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/091aa4641fcd7ecb421b8241720b...

Powered by Google App Engine
This is Rietveld 408576698